Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for defaultSelectedItem. #2920

Merged
merged 5 commits into from
Sep 12, 2018
Merged

Added support for defaultSelectedItem. #2920

merged 5 commits into from
Sep 12, 2018

Conversation

danilotorrisi
Copy link
Contributor

@danilotorrisi danilotorrisi commented Sep 10, 2018 •
edited
Loading

Fixes #2784

Checklist

Changes proposed in this pull request:

Fixes #2784.

Reviewers should focus on:

The Suggest now accepts a defaultSelectedItem prop to set the initial value of the component in uncontrolled mode ( default uncontrolled state ).

giladgray
giladgray suggested changes Sep 11, 2018
View reviewed changes
Copy link
Contributor

@giladgray giladgray left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there @danilotorrisi , just some polish needed

packages/select/src/components/select/suggest.tsx Outdated Show resolved Hide resolved
packages/select/src/components/select/suggest.tsx Outdated Show resolved Hide resolved
packages/select/src/components/select/suggest.tsx Show resolved Hide resolved
packages/select/test/suggestTests.tsx Outdated Show resolved Hide resolved
packages/select/test/suggestTests.tsx Outdated Show resolved Hide resolved
packages/select/src/components/select/suggest.tsx Outdated Show resolved Hide resolved
giladgray
giladgray approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change looks good but let's wax philosophical on comment theory for a moment 😄

packages/select/src/components/select/suggest.tsx Outdated Show resolved Hide resolved
packages/select/src/components/select/suggest.tsx Outdated Show resolved Hide resolved
@giladgray giladgray merged commit ddb2dbf into palantir:develop Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladgray giladgray giladgray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danilotorrisi @giladgray