Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Switch] Fix indicator when line-height != 1 #2929

Merged
merged 1 commit into from
Sep 12, 2018
Merged

[Switch] Fix indicator when line-height != 1 #2929

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/components/forms/_controls.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ $control-indicator-spacing: $pt-grid-size !default;
transition: background-color $pt-transition-duration $pt-transition-ease;

&::before {
position: relative;
position: absolute;
left: 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, how was left: 0 even supposed to do anything when position: relative

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was more about the left when :checked but yea the issue here was obvious

margin: $switch-indicator-margin;
border-radius: 50%;
Expand Down