Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable port configuration in webpack dev server. Closes #2921 #2930

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

james2doyle
Copy link
Contributor

@james2doyle james2doyle commented Sep 12, 2018

Fixes #2921

Changes proposed in this pull request:

Allows configuring the webpack dev server port

Reviewers should focus on:

Running the dev server with and without the PORT env set

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @james2doyle! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks @james2doyle

@giladgray giladgray merged commit 9d22ad8 into palantir:develop Sep 12, 2018
@james2doyle james2doyle deleted the jd/webpack-server-port branch September 12, 2018 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants