[hotkeys] Fix sorting for global hotkey groups with labels #2938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/blueprint, @jeroenvisser101! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
jeroenvisser101
force-pushed
the
jeroenvisser101/global-hotkey-sorting
branch
from
2af74d4
to
7712ea8
Compare
giladgray
suggested changes
Sep 14, 2018
| hotkeys.sort((a, b) => { | ||
| if (a.global) { | ||
| return b.global ? 0 : -1; | ||
| if ((a.global && b.global) || (!a.global && !b.global)) { |
There was a problem hiding this comment.
how about if (a.global === b.global)?
There was a problem hiding this comment.
Ah! That's a good one
There was a problem hiding this comment.
cool, waiting for a push from you.
Hotkey groups with names that are have the global={true} prop should
now also be alphabetically sorted.
Fixes palantir#2439
jeroenvisser101
force-pushed
the
jeroenvisser101/global-hotkey-sorting
branch
from
7712ea8
to
090dbd4
Compare
|
@giladgray I added tests, and they do test the sorting, but they only test the appearance order of the labels. I think that should do it, but please let me know if there are better ways of doing that. |
giladgray
approved these changes
Sep 20, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hotkey groups with labels that are have the global={true} prop should
now also be alphabetically sorted.
Fixes #2439
Changes proposed in this pull request:
The change will prioritize global hotkeys, but still sort them with other global hotkey groups. If a hotkey group is both global but also has a group name, it will still sort it alphabetically.
Reviewers should focus on:
Sorting and order of global hotkey groups with a group name set.