[DatePicker] add props to set datepicker action bar buttons title #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladgray
suggested changes
Sep 14, 2018
|
@NachoJusticia have you signed the CLA? sometimes it goes yellow on its own so just checking. |
|
Hi @giladgray |
|
@NachoJusticia ok cool. mind pushing an empty commit to trigger an update? |
|
Hi again @giladgray , I have just pushed an empty commit as you suggested me and now cla step is passing 👍 |
giladgray
approved these changes
Sep 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2861
Changes proposed in this pull request:
Add
todayButtonTextandclearButtonTextprops to DatePicker component so these titles can be set from outside.Reviewers should focus on:
They way
todayButtonTextandclearButtonTextprops has been added to datePicker component and its jsdoc comments.Screenshot