Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Upgrade to latest React types #2951

Merged
merged 6 commits into from
Sep 20, 2018
Merged

🔧 Upgrade to latest React types #2951

merged 6 commits into from
Sep 20, 2018

Conversation

giladgray
Copy link
Contributor

  • use latest react types and fix compile errors.
  • changes in findDOMNode (can now return Text element), stricter CSS types, and prop-types complains loudly about "cannot be named" symbols.

@blueprint-bot
Copy link

fix compile errors

Previews: documentation | landing | table

@blueprint-bot
Copy link

fix tests

Previews: documentation | landing | table

@blueprint-bot
Copy link

fix test again

Previews: documentation | landing | table

@blueprint-bot
Copy link

lint

Previews: documentation | landing | table

Copy link
Contributor

@themadcreator themadcreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting aside, looks good

@@ -9,7 +9,7 @@
import { expect } from "chai";
import { mount, ReactWrapper } from "enzyme";
import * as React from "react";
import * as ReactDOM from "react-dom";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

@blueprint-bot
Copy link

whitespace

Previews: documentation | landing | table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants