Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Drawer component #2957

Merged
merged 19 commits into from
Feb 7, 2019
Merged

New Drawer component #2957

merged 19 commits into from
Feb 7, 2019

Conversation

pkwi
Copy link
Contributor

@pkwi pkwi commented Sep 20, 2018

A drawer is a UI component that overlays on top of an existing UI to display additional content.

@pkwi pkwi requested a review from giladgray September 20, 2018 11:01
@blueprint-bot
Copy link

add files

Previews: documentation | landing | table

@blueprint-bot
Copy link

fixed styling

Previews: documentation | landing | table

@blueprint-bot
Copy link

dark theme added

Previews: documentation | landing | table

@blueprint-bot
Copy link

Added vertical orientation

Previews: documentation | landing | table

@blueprint-bot
Copy link

Merge branch 'develop' of github.com:palantir/blueprint into pk/drawer

Previews: documentation | landing | table

@blueprint-bot
Copy link

changed viewport units

Previews: documentation | landing | table

@blueprint-bot
Copy link

Added small and large sizes

Previews: documentation | landing | table

@blueprint-bot
Copy link

Standardized sizing

Previews: documentation | landing | table

packages/core/src/components/drawer/drawer.md Show resolved Hide resolved
packages/core/src/components/drawer/drawer.tsx Outdated Show resolved Hide resolved
packages/core/src/components/drawer/drawer.tsx Outdated Show resolved Hide resolved
packages/core/src/components/drawer/drawer.tsx Outdated Show resolved Hide resolved
packages/core/src/components/drawer/drawer.tsx Outdated Show resolved Hide resolved
@blueprint-bot
Copy link

backdrop fixed

Previews: documentation | landing | table

@adamstorr
Copy link
Contributor

@pkwi what's the state of this?

@giladgray
Copy link
Contributor

needs tests and polish.

@blueprint-bot
Copy link

Merge branch 'develop' of github.com:palantir/blueprint into pk/drawer

Previews: documentation | landing | table

@ptvandi
Copy link

ptvandi commented Dec 23, 2018

I just started to build this myself and am really excited to have found that it's in the works. Thank you and well done!

@blueprint-bot
Copy link

Merge branch 'develop' of github.com:palantir/blueprint into pk/drawer

Previews: documentation | landing | table

@giladgray giladgray changed the title [WIP] New Drawer component New Drawer component Feb 6, 2019
@blueprint-bot
Copy link

size prop docs

Previews: documentation | landing | table

@blueprint-bot
Copy link

fix isotest

Previews: documentation | landing | table

@blueprint-bot
Copy link

add size+vertical tests, actually run suite

Previews: documentation | landing | table

@giladgray giladgray merged commit a44ce29 into develop Feb 7, 2019
@giladgray giladgray deleted the pk/drawer branch February 7, 2019 01:21
@Abhijith126
Copy link

Abhijith126 commented Mar 1, 2019

Is it possible for the drawer to be on the left side?
I was able to get the drawer to left by setting style left:0 but the animation of closing and opening is happening towards the right.
<Drawer style={{ left: '0', transition: 'all 0.1s' }} isOpen={isDrawerOpen} size={'250px'} usePortal={true} hasBackdrop={true} canOutsideClickClose={true} onClose={() => toggleDrawer(false)} >

Please help

@adidahiya
Copy link
Contributor

@Darkness126 check out the open issues, there are a few open ones about that #3360. It's almost always better to file a new issue rather than comment on a closed PR.

@palantir palantir locked as resolved and limited conversation to collaborators Mar 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants