Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog] Minimal button for dialog close button #2964

Merged
merged 3 commits into from
Sep 21, 2018
Merged

[Dialog] Minimal button for dialog close button #2964

merged 3 commits into from
Sep 21, 2018

Conversation

pkwi
Copy link
Contributor

@pkwi pkwi commented Sep 21, 2018

Fixes #2963

@pkwi pkwi requested a review from giladgray September 21, 2018 14:31
@blueprint-bot
Copy link

use minimal button for dialog close

Previews: documentation | landing | table

@blueprint-bot
Copy link

fixed tests

Previews: documentation | landing | table

giladgray
giladgray approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@giladgray giladgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@blueprint-bot
Copy link

use large close icon

Previews: documentation | landing | table

@giladgray giladgray merged commit 1b9687c into develop Sep 21, 2018
@giladgray giladgray deleted the pk/dialog-close-button branch September 21, 2018 16:22
@giladgray giladgray mentioned this pull request Dec 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giladgray giladgray giladgray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkwi @blueprint-bot @giladgray