Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Input/InputGroup/TextArea] small modifier follow-ups #2992

Merged
merged 4 commits into from
Oct 4, 2018
Merged

[Input/InputGroup/TextArea] small modifier follow-ups #2992

merged 4 commits into from
Oct 4, 2018

Conversation

giladgray
Copy link
Contributor

@giladgray giladgray commented Oct 4, 2018 •
edited
Loading

Follow-ups from #2953

Changes proposed in this pull request:

  • adjust newly added variables a bit so small inputs sit better.
    • smaller buttons are a little bigger so there's more space around icon
    • adjust input small padding so icon remains centered
  • fix font icon size in input-group CSS example
  • fix padding on small+round inputs
  • refactor <textarea> styles to better support small/large sizes
  • add TextArea small prop

Screenshots

before (#2953) after (this PR)
image image
image image

cc @tnrich. thank you for getting this started!

@blueprint-bot
Copy link

refactor textarea styles, add small prop to component

Previews: documentation | landing | table

@blueprint-bot
Copy link

refactor textarea styles, add small prop to component

Previews: documentation | landing | table

themadcreator
themadcreator approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@themadcreator themadcreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small awkwardness if they set both large and small to true.

@giladgray giladgray merged commit b883c6f into develop Oct 4, 2018
@giladgray giladgray deleted the gg/small-input-flups branch October 4, 2018 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themadcreator themadcreator themadcreator approved these changes

Assignees
No one assigned
Labels
Type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giladgray @blueprint-bot @themadcreator