Move focus style manager to its own file #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giladgray
approved these changes
Dec 5, 2016
giladgray
suggested changes
Dec 5, 2016
| @@ -0,0 +1,18 @@ | |||
| /* | |||
| * Copyright 2015 Palantir Technologies, Inc. All rights reserved. | |||
| @@ -0,0 +1,8 @@ | |||
| /* | |||
| * Copyright 2015 Palantir Technologies, Inc. All rights reserved. | |||
|
Love hygiene 👍 |
adidahiya
commented
Dec 5, 2016
|
|
||
| import { InteractionModeEngine } from "../common/interactionMode"; | ||
|
|
||
| export const FOCUS_DISABLED_CLASS = "pt-focus-disabled"; |
There was a problem hiding this comment.
this should probably live in the Classes export... but unfortunately that would be a small breaking change.
There was a problem hiding this comment.
could keep this line marked deprecated.
/** @deprecated */
export const FOCUS_DISABLED_CLASS = Classes.FOCUS_DISABLED_CLASS;
giladgray
approved these changes
Dec 5, 2016
cmslewis
approved these changes
Dec 5, 2016
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
core/src/accessibility/folderThis is mostly just for good hygiene. Feels weird to have the focus stuff in index.ts.