use TSLint for JS files too #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 7, 2016 16:30
mostly alphabetizing objects.
adidahiya
approved these changes
Dec 8, 2016
| // synchronously read and return string content of file. | ||
| fromFile: (filepath) => fs.readFileSync(filepath, "utf8"), | ||
|
|
||
| highlight: highlight, |
There was a problem hiding this comment.
this should be flagged as a failure by object-literal-shorthand... what's going on?
There was a problem hiding this comment.
huh that rule had to be explicitly enabled here
There was a problem hiding this comment.
weird, it's enabled in the recommended config: https://github.com/palantir/tslint/blob/47212df6d3e97eb1e2da6ed0d1fb43cda4e32126/src/configs/recommended.ts#L79
| @@ -91,16 +91,16 @@ module.exports = (gulp, plugins, blueprint) => { | |||
|
|
|||
| gulp.task(`karma-unit-${project.id}`, (done) => { | |||
| const config = Object.assign(createConfig(project), { | |||
| reporters: [ "mocha" ], | |||
| singleRun: false, | |||
| browsers: ["Chrome"], | |||
There was a problem hiding this comment.
nit: inconsistent spacing inside [ ]
Merged
greglo
pushed a commit
to greglo/blueprint
that referenced
this pull request
Dec 12, 2016
* use TSLint 4.x to lint JS files too! mostly alphabetizing objects. * remove eslint * fix `check` task alias * spacing, object shorthand
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request: