Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[table] fix(Cell): only modify props for specific child elements #3630

Merged
merged 2 commits into from
Apr 20, 2020

Conversation

dalaicam
Copy link
Contributor

@dalaicam dalaicam commented Jun 27, 2019

Console message: "Warning: React does not recognize the parentCellWidth prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase parentcellwidth instead. If you accidentally passed it from a parent component, remove it from the DOM element."

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Console message: "Warning: React does not recognize the `parentCellWidth` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `parentcellwidth` instead. If you accidentally passed it from a parent component, remove it from the DOM element."
@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @dalaicam! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you further describe your issue? What is the use case here? Can you demonstrate it in a code sandbox? Can you add a unit test for this change?

@dalaicam
Copy link
Contributor Author

This is minor issue/fix as doesn't seem to influence the behavior other than filling up the console with warnings.

To replicate, simply add a button to Cell component, not sure if affects other components. Tho, based on the comment and the if conditions it should only affect the TruncatedFormat and JSONFormat.
The if, as it is (before this change), affects all components.

Code example of issue:
https://codesandbox.io/s/blueprint-sandbox-4sf1t

@muratbeser
Copy link

I'm also effected by this issue.

@adidahiya adidahiya changed the title Fixed: Issue when button is defined inside a Cell. [table] fix(Cell): only modify props for TruncatedFormat/JSONFormat children Apr 20, 2020
@adidahiya adidahiya changed the title [table] fix(Cell): only modify props for TruncatedFormat/JSONFormat children [table] fix(Cell): only modify props for specific child elements Apr 20, 2020
@adidahiya adidahiya merged commit 8f7ae5f into palantir:develop Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants