Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crashing on inputs with type number. #3672

Merged
merged 3 commits into from
Jul 25, 2019
Merged

Fix crashing on inputs with type number. #3672

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc38596
Fix crashing on inputs with type number.
vadzim Jul 24, 2019
08dcc16
linting
vadzim Jul 24, 2019
90f26fd
remove extra space
vadzim Jul 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions packages/core/src/components/editable-text/editableText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ export interface IEditableTextProps extends IIntentProps, IProps {
/**
* Whether the entire text field should be selected on focus.
* If `false`, the cursor is placed at the end of the text.
* This prop is ignored on inputs with type other then text, search, url, tel and password. See https://html.spec.whatwg.org/multipage/input.html#do-not-apply for details.
* @default false
*/
selectAllOnFocus?: boolean;
Expand Down Expand Up @@ -142,9 +143,12 @@ export class EditableText extends AbstractPureComponent<IEditableTextProps, IEdi
input: (input: HTMLInputElement | HTMLTextAreaElement) => {
if (input != null) {
input.focus();
const { length } = input.value;
input.setSelectionRange(this.props.selectAllOnFocus ? 0 : length, length);
if (!this.props.selectAllOnFocus) {
const supportsSelection = inputSupportsSelection(input);
if (supportsSelection) {
const { length } = input.value;
input.setSelectionRange(this.props.selectAllOnFocus ? 0 : length, length);
}
if (!supportsSelection || !this.props.selectAllOnFocus) {
input.scrollLeft = input.scrollWidth;
}
}
Expand Down Expand Up @@ -392,3 +396,21 @@ function insertAtCaret(el: HTMLTextAreaElement, text: string) {
el.selectionEnd = selectionStart + len;
}
}

function inputSupportsSelection(input: HTMLInputElement | HTMLTextAreaElement) {
switch (input.type) {
// HTMLTextAreaElement
case "textarea":
return true;
// HTMLInputElement
// see https://html.spec.whatwg.org/multipage/input.html#do-not-apply
case "text":
case "search":
case "tel":
case "url":
case "password":
return true;
default:
return false;
}
}