Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resources] add icons sketch library #3933

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

estevesd
Copy link
Contributor

Add Sketch Library for icons

Changes proposed in this pull request:

Add a separate Sketch Library for Icons.
16/20px, dark/Light versions are available for easy of use in sketch
Nested components allow overrides with shared styles.
Icons are organised by categories like on the docs

Reviewers should focus on:

Is it useful for everyone? or only me?

Screenshot

blueprint-icons-library

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @estevesd! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@estevesd
Copy link
Contributor Author

based on discussions in #2817
the icons have been added in the kit instead of a separate library.
shall we keep it like this or still do a separate library only for icons ?

@aycai
Copy link
Contributor

aycai commented Jan 24, 2020

I think for now keeping it in the kit file (as is) works. I'm wary of perf, but it seems to work fine so far.

I was going to say that you don't need separate symbols for dark and light, but checking your file in #2817 looks like you fixed that :)

Changes in there look good as well 👍

@aycai aycai self-requested a review January 24, 2020 00:09
@adidahiya adidahiya changed the title add separate icons sketch library, 16/20px, dark/light. With nested components [resources] add icons sketch library Apr 14, 2020
@adidahiya adidahiya merged commit 78e16b9 into palantir:develop Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants