Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] feat: Added virus icon #4050

Merged
merged 4 commits into from
Apr 9, 2020
Merged

[icons] feat: Added virus icon #4050

merged 4 commits into from
Apr 9, 2020

Conversation

jbcolin18
Copy link
Contributor

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Added virus icon to icon library approved by other Palantir designers. I didn't add legacy file types.

Reviewers should focus on:

Icons should render as below screenshot.

Screenshot

Screen Shot 2020-04-08 at 1 33 12 PM

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @jbcolin18! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@adidahiya
Copy link
Contributor

The icon doesn't show up correctly with the <Icon> react component. I think it's because multiple paths are used. In theory, this should be ok (we should be able to render such SVGs into the DOM), but in practice, it looks like all other icons in Blueprint are drawn with a single <path>, even for disjoint shapes:

layout-grid:

image

virus:

image

is there any way you can configure the export from Sketch to only draw one <path> in the icon contents?

@adidahiya
Copy link
Contributor

Actually this could be a problem in the way we optimize svgs with svgo... i'm taking a closer look

"displayName": "Virus",
"iconName": "virus",
"tags": "virus, doctor, medical, examination, disease, pandemic, sick",
"group": "interface"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the "content" field here because it was unused, and I changed the build scripts to allow for this omittance

@adidahiya adidahiya changed the title Added virus icon [icons] feat: Added virus icon Apr 9, 2020
@adidahiya adidahiya merged commit 48aad0e into palantir:develop Apr 9, 2020
@adidahiya adidahiya mentioned this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants