chore: reconfigure ESLint again, move prettier to monorepo root #4080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: reconfigure ESLint again, move prettier to monorepo rootPreviews: documentation | landing | table |
set eslint env correctly, run it on build script sourcesPreviews: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In hindsight, it was a little weird having the blueprint eslint-config configure prettier, especially as we're moving towards running it as a separate CLI task in CI environments.
This PR removes the
eslint-config-prettierandeslint-plugin-prettierdependencies from@blueprintjs/eslint-configand adds them to the monorepo root, where they are easily configured in a few lines in.eslintrc.jsdepending on whether we are in a CI environment or not.This PR also changes
@blueprint/eslint-configso that it can lint itself and other.jsnode script modules. We now use the standard EStree parser for these files and set the correct ES version and environment.