Add support for callback ref and ref hook #4093

tanmoyopenroot · 2020-04-25T15:09:12Z

Fixes #4064

Checklist

Includes tests
Update documentation

Changes proposed in this pull request:

Add support for callback ref and ref hook for Button, Anchor Button and InputGroup

Reviewers should focus on:

Typing for the props(elementRef, inputRef)

tanmoyopenroot · 2020-04-26T09:20:02Z

@adidahiya Currently test-react-15 is failing as hooks are not available.
Is there any way we can detect react version to skip those test?

packages/core/src/components/button/abstractButton.tsx

packages/core/test/buttons/buttonTests.tsx

adidahiya · 2020-05-19T21:30:54Z

docs preview

adidahiya

overall this works, there are some stylistic refactors I'd like to do on top of this to make the implementation less verbose, but I'll merge and do that on develop to get this moving along

adidahiya · 2020-05-19T21:31:40Z

thanks @tanmoyopenroot!

adidahiya suggested changes May 6, 2020

View reviewed changes

packages/core/src/components/button/abstractButton.tsx Outdated Show resolved Hide resolved

packages/core/test/buttons/buttonTests.tsx Outdated Show resolved Hide resolved

tanmoyopenroot added 9 commits May 9, 2020 20:20

fix(abstract-button): handle callback ref as well as ref hook

dc5a35d

test(abstract-button): add test to verify callback ref and ref hook

93e36c2

fix(input-group): fix inputRef prop to support callback and ref hook

716396d

lint(button-test): remove whitespace within parentheses

8a89300

fix(prettier): run prettier in changed files

dd2fc9a

fix(abstract-button): replace react's refObject with custom one

703ab5a

fix(prettier): run prettier in changed files

38f4207

chore(abstract-button): remove dead code

11a7da4

fix(date-range-input): check for inputref

382b744

tanmoyopenroot force-pushed the 4064-support-for-ref-hook branch from c867564 to 382b744 Compare May 9, 2020 15:13

tanmoyopenroot added 2 commits May 9, 2020 20:51

fix(prettier): run prettier in changed files

2f94da0

test(button): wrap test to check for feture existence

1fae1ef

adidahiya approved these changes May 19, 2020

View reviewed changes

adidahiya merged commit 263d4df into palantir:develop May 19, 2020

tanmoyopenroot deleted the 4064-support-for-ref-hook branch May 20, 2020 02:41

adidahiya mentioned this pull request May 20, 2020

chore: refactor ref handler changes from #4093 #4140

Merged

1 task

adidahiya added a commit that referenced this pull request May 21, 2020

chore: refactor ref handler changes from #4093 (#4140)

f53aa75

adidahiya mentioned this pull request May 22, 2020

Suggest dropdown does not open when inputRef is set to ref hook #4138

Closed

appleneil mentioned this pull request Jan 27, 2021

Support for ref objects in NumericInput inputRef prop #4382

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for callback ref and ref hook #4093

Add support for callback ref and ref hook #4093

tanmoyopenroot commented Apr 25, 2020 •

edited

Loading

tanmoyopenroot commented Apr 26, 2020 •

edited

Loading

adidahiya commented May 19, 2020

adidahiya left a comment

adidahiya commented May 19, 2020

Add support for callback ref and ref hook #4093

Add support for callback ref and ref hook #4093

Conversation

tanmoyopenroot commented Apr 25, 2020 • edited Loading

Fixes #4064

Checklist

Changes proposed in this pull request:

Reviewers should focus on:

tanmoyopenroot commented Apr 26, 2020 • edited Loading

adidahiya commented May 19, 2020

adidahiya left a comment

Choose a reason for hiding this comment

adidahiya commented May 19, 2020

tanmoyopenroot commented Apr 25, 2020 •

edited

Loading

tanmoyopenroot commented Apr 26, 2020 •

edited

Loading