Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] feat: add inherited group membership icon #4097

Merged
merged 5 commits into from
Apr 27, 2020

Conversation

kaatherine
Copy link
Contributor

Fixes #0000

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Add pt-icon-inherited-group to the BP icon library

Reviewers should focus on:

Screenshot

80154004-89ed8780-8573-11ea-861b-102a713b56c8

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @kaatherine! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

@@ -0,0 +1,14 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is missing the .svg file extension, which is expected by the compile script:

lerna ERR! yarn run compile stderr:
 
(node:254) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open '/home/circleci/project/resources/icons/16px/inherited-group.svg'
 

@adidahiya adidahiya changed the title Add Inherited group membership icon [icons] feat: add inherited group membership icon Apr 27, 2020
@adidahiya adidahiya merged commit 5c14db3 into palantir:develop Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants