Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date picker's time buttons alignment #4115

Merged

Conversation

tuluce
Copy link
Member

@tuluce tuluce commented May 9, 2020

Fixes #4057

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

In order to fix the alignment of the time picker's buttons, a wrapper is added for the time picker component of date picker.

Reviewers should focus on:

Screenshot

Before:
ss_before

After
ss_after

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @eminbahadir98! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks! I'll add a follow-up commit to make this easier to test in the docs example

@adidahiya adidahiya merged commit 3afdbef into palantir:develop May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time arrows misaligned in date picker
3 participants