Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add focus and keyboard events control to TimePicker #4123

Merged
merged 1 commit into from
May 21, 2020
Merged

Add focus and keyboard events control to TimePicker #4123

merged 1 commit into from
May 21, 2020

Conversation

alxmiron
Copy link
Contributor

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Add more control over inputs in TimePicker. In some cases (e.g. navigation with hotkeys) it requires to control keydown, keyup, blur, focus events

adidahiya
adidahiya approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and straightforward, looks good

@adidahiya adidahiya merged commit ebfb23f into palantir:develop May 21, 2020
@alxmiron alxmiron deleted the am/timepicker-keys-control branch May 22, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alxmiron @adidahiya