Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[select] fix(MultiSelect): create new item with IME #4137

Merged
merged 3 commits into from
May 20, 2020
Merged

[select] fix(MultiSelect): create new item with IME #4137

merged 3 commits into from
May 20, 2020

Conversation

adidahiya
Copy link
Contributor

Fixes #4128

thanks to @AaronJRubin for the proposal in #4134... this is a slightly different implementation which avoids using this.state since this boolean flag shouldn't cause a re-render of the component

Checklist

  • Includes tests
  • N/A Update documentation

@blueprint-bot
Copy link

fix select component test suite

Previews: documentation | landing | table

@AaronJRubin
Copy link
Contributor

I confirm that this resolves the IME issue!

@blueprint-bot
Copy link

use flag for enter key only

Previews: documentation | landing | table

@adidahiya adidahiya merged commit c96f8d2 into develop May 20, 2020
@adidahiya adidahiya deleted the ad/multiselect-keydown branch May 20, 2020 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@adidahiya @blueprint-bot @AaronJRubin