Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(suggest): check for refObject or callback on popup interaction #4147

Merged
merged 1 commit into from
May 23, 2020
Merged

fix(suggest): check for refObject or callback on popup interaction #4147

merged 1 commit into from
May 23, 2020

Conversation

tanmoyopenroot
Copy link
Contributor

Fixes #4138

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

check for refObject or callback on popup interaction

Screenshot

Visual Test
Screenshot 2020-05-23 at 6 38 07 AM

Code used to test
Screenshot 2020-05-23 at 6 37 40 AM

adidahiya
adidahiya approved these changes May 23, 2020
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep this works, just tried it out locally, thanks for the quick turn around @tanmoyopenroot

@adidahiya adidahiya merged commit a44fdec into palantir:develop May 23, 2020
@tanmoyopenroot tanmoyopenroot deleted the 4138-fix-inputRef-for-hooks branch May 23, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanmoyopenroot @adidahiya