Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix(ControlGroup): margin around dividers #4215

Merged
merged 5 commits into from
Jul 22, 2020

Conversation

Arbalester
Copy link
Contributor

Fixes #3919

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Added style exception for divider inside .
Added additional margin-left for divider if it is inside and element on left has margin-right = -1px.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @Arbalester! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please hold off on this, see discussion in #3919 (comment)

@adidahiya adidahiya changed the title fix divider in control group [core] fix(ControlGroup): margin around dividers Jul 22, 2020
@adidahiya adidahiya merged commit 8a8de97 into palantir:develop Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dividers in Control Groups have incorrect margins
3 participants