Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[datetime] fix(DatePicker): prevent iOS crash selecting month/year #4245

Merged
merged 1 commit into from
Jul 28, 2020
Merged

[datetime] fix(DatePicker): prevent iOS crash selecting month/year #4245

merged 1 commit into from
Jul 28, 2020

Conversation

jez321
Copy link
Contributor

@jez321 jez321 commented Jul 24, 2020

Fixes #4178

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Ignore invalid values passed to the month/year select change handler to prevent a crash on Safari on iOS.

Reviewers should focus on:

  • Whether the referenced bug has been fixed.
  • Whether silently rejecting invalid values is acceptable or if it could make debugging harder in the future.

Screenshot

Before After
HCSF6027 (1) ETUX2092

@adidahiya adidahiya changed the title Ignore invalid month/year change events to prevent iOS Safari crash [datetime] fix(DatePicker): prevent iOS crash selecting month/year Jul 28, 2020
@adidahiya adidahiya merged commit c51f18e into palantir:develop Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DatePicker: Selecting "Year" then "Month" on iOS causes component to throw error
2 participants
@jez321 @adidahiya