Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] fix(Tag): remove button has tabIndex if interactive #4255

Merged
merged 2 commits into from
Aug 5, 2020
Merged

[core] fix(Tag): remove button has tabIndex if interactive #4255

merged 2 commits into from
Aug 5, 2020

Conversation

mattydono
Copy link
Contributor

@mattydono mattydono commented Jul 31, 2020

multi-select tag remove button now tabs only when tabbing for tag implemented

Fixes #4247

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Tabbing of the remove button is aligned with the tag itself.

Reviewers should focus on:

Just a quick fix that makes all elements of the tag 'tabbable' or not depending upon whether interactive = true and a tabIndex has been set.

@palantirtech
Copy link
Member

Thanks for your interest in palantir/blueprint, @mattydono! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request.

Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but failing format-check... please run yarn format from the root of the repo

@adidahiya adidahiya changed the title multi-select tag remove button now tabs only when tabbing for tag imp… [core] fix(Tag): remove button applies accessible tabIndex if interactive Aug 5, 2020
@adidahiya adidahiya changed the title [core] fix(Tag): remove button applies accessible tabIndex if interactive [core] fix(Tag): remove button has tabIndex if interactive Aug 5, 2020
@adidahiya adidahiya merged commit 1763384 into palantir:develop Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application of tabIndex to remove button within muli-select tag
3 participants