[core] fix(EditableText): add small width buffer to prevent crash #4268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
approved these changes
Aug 7, 2020
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4267
I've tested this PR against the application where we originally noticed the crash, and confirmed it does fix the problem.
Checklist
Changes proposed in this pull request:
Add a small buffer to scrollWidth in EditableText to prevent the infinite loop described in #4267
Before this PR we only added the buffer for IE and Edge. This PR makes it so we add the buffer for all browsers.
Reviewers should focus on:
Is this really the "right" fix? Or is this just a patch over a deeper issue?