[core] fix(TextArea): inputRef ref hook usage #4296
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/blueprint, @weilandia! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
weilandia
force-pushed
the
nw/4294-text-area-refs
branch
from
87520c2
to
185d8b9
Compare
2 tasks
|
I pushed a similar but slightly different implementation here: #4338. It matches some of the other components which deal with ref objects. It ends up being more verbose, which I don't love, so I may reconsider this approach across the board for those components in a future refactor... but for now I'm going to go with consistency. Thanks for the PR |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4294
Checklist
Changes proposed in this pull request:
Allow TextArea to receive an IRefObject for the InputRef. Change IRefObject.current to not be readonly.
Reviewers should focus on:
Never used Typescript, so I may be doing weird things...