Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[select] feat: pass create item renderer to item list renderer #4303

Merged
merged 6 commits into from
Sep 2, 2020
Merged

[select] feat: pass create item renderer to item list renderer #4303

merged 6 commits into from
Sep 2, 2020

Conversation

rhysbrettbowen
Copy link
Contributor

@rhysbrettbowen rhysbrettbowen commented Sep 1, 2020 •
edited
Loading

Fixes #4302, fixes #4031

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • pass in renderCreateItem to the itemListRenderer which will render the custom item using the passed in props

Reviewers should focus on:

Screenshot

adidahiya
adidahiya suggested changes Sep 2, 2020
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what happened with your build but if you turned on CI for your fork, I would suggest turning it off (as noted in CONTRIBUTING.md)

packages/select/src/common/itemListRenderer.ts Outdated Show resolved Hide resolved
packages/select/src/common/itemListRenderer.ts Outdated Show resolved Hide resolved
packages/select/src/components/query-list/queryList.tsx Outdated Show resolved Hide resolved
packages/select/src/components/query-list/queryList.tsx Outdated Show resolved Hide resolved
packages/select/src/components/query-list/queryList.tsx Outdated Show resolved Hide resolved
packages/select/src/components/query-list/queryList.tsx Outdated Show resolved Hide resolved
packages/select/src/components/query-list/queryList.tsx Outdated Show resolved Hide resolved
@adidahiya adidahiya mentioned this pull request Sep 2, 2020
Closed
@rhysbrettbowen
Copy link
Contributor Author

Not sure how to turn off circleci in the fork, I removed the circleci webhook in settings.

@adidahiya adidahiya changed the title Pass in create item to item list render [select] feat: pass create item renderer to item list renderer Sep 2, 2020
@adidahiya adidahiya merged commit 9bce0cd into palantir:develop Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@rhysbrettbowen @adidahiya @blueprint-bot