Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] fix(Button): always exit active state if blurred #4309

Merged
merged 2 commits into from
Sep 21, 2020
Merged

[core] fix(Button): always exit active state if blurred #4309

merged 2 commits into from
Sep 21, 2020

Conversation

jaamison
Copy link
Contributor

@jaamison jaamison commented Sep 3, 2020

Fixes #3977

Changes proposed in this pull request:

Add an onBlur handler passed to the button component that unsets the local component isActive state on DOM blur events if necessaary.

@adidahiya adidahiya self-requested a review September 3, 2020 19:35
@adidahiya adidahiya changed the title Fixes #3977 [core] fix(Button): always exit active state if blurred Sep 21, 2020
@adidahiya adidahiya merged commit 382a638 into palantir:develop Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Button can become stuck in pressed state
2 participants
@jaamison @adidahiya