New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] abstractButton: remove reliance on getDerivedStateFromProps #4310

Merged

adidahiya merged 1 commit into palantir:develop from jaamison:jj/button-cleanup

Sep 3, 2020

Contributor

jaamison commented Sep 3, 2020

PR removes an unnecessary call to getDerivedStateFromProps on each render cycle. React maintainers generally consider this an anti-pattern.


          [core] abstractButton: remove reliance on getDerivedStateFromProps li…

5f1e5e9

…fecycle method

adidahiya approved these changes

View reviewed changes

adidahiya merged commit 90db227 into palantir:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet