[core] fix(InputGroup): better support for async controlled updates #4323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[core] fix(InputGroup): better support for async controlled updatesPreviews: documentation | landing | table |
better fixPreviews: documentation | landing | table |
update inputgroup example to test the bugPreviews: documentation | landing | table |
fix state change when setting pendingUpdate: truePreviews: documentation | landing | table |
update DRI tests to be less tightly coupled with InputGroup implPreviews: documentation | landing | table |
mention async updates in docsPreviews: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4298
Checklist
Changes proposed in this pull request:
Refactor
<AsyncControllableInput>, using a different approach (only very tangentially adapted from facebook/react#14904 (comment)) which avoids the issue of the cursor jumping to the end of the input.Reviewers should focus on:
Should fix the linked issue and not cause a regression for issue described in #4262
Screenshot (latest, from fdfdffb)
Screenshot (outdated, from the version at 3716788)
Seems to fix #4320 as well: