Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] feat(Text): add title prop #4334

Merged
merged 2 commits into from
Sep 21, 2020
Merged

[core] feat(Text): add title prop #4334

merged 2 commits into from
Sep 21, 2020

Conversation

ejose19
Copy link
Contributor

@ejose19 ejose19 commented Sep 16, 2020

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Adds title prop to Text element and adjust all dependant components so they can pass that property.

adidahiya
adidahiya suggested changes Sep 21, 2020
View reviewed changes
packages/core/src/components/tag/tag.tsx Outdated Show resolved Hide resolved
packages/core/src/components/panel-stack/panelView.tsx Outdated Show resolved Hide resolved
@adidahiya adidahiya changed the title [core] refactor(Text): add title prop to text component [core] feat(Text): add title prop Sep 21, 2020
adidahiya
adidahiya approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ejose19

@adidahiya adidahiya merged commit 7a7af21 into palantir:develop Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ejose19 @adidahiya