[icons] feat: data-connection icon #4336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your interest in palantir/blueprint, @jheadrick2! Before we can accept your pull request, you need to sign our contributor license agreement - just visit https://cla.palantir.com/ and follow the instructions. Once you sign, I'll automatically update this pull request. |
adidahiya
reviewed
Sep 21, 2020
| @@ -0,0 +1,20 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
the name of this file does not match the icon name. it must be data-connection.svg, as shown in the build failure:
lerna ERR! yarn run compile stderr:
(node:248) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open '/home/circleci/project/resources/icons/16px/data-connection.svg'
adidahiya
reviewed
Sep 21, 2020
|
the icon doesn't show up correctly, it renders a blank box:
|
adidahiya
suggested changes
Sep 21, 2020
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <svg width="16px" height="16px" viewBox="0 0 16 16" version="1.1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink"> | ||
| <title>bp3-data-connection</title> | ||
| <defs> |
There was a problem hiding this comment.
please re-export these icons with simpler SVG definitions similar to the other icons in the repo. see my comment here #4132 (comment)
adidahiya
reviewed
Sep 21, 2020
|
docs preview looks good |
adidahiya
approved these changes
Sep 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Checklist
Changes proposed in this pull request:
New Icon!
Reviewers should focus on:
Screenshot