Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] chore: enable strict null checks #4346

Merged
merged 7 commits into from
Sep 29, 2020
Merged

Conversation

adidahiya
Copy link
Contributor

Part of #325

@@ -26,13 +26,13 @@ export interface IPanelViewProps {
* Callback invoked when the user presses the back button or a panel invokes
* the `closePanel()` injected prop method.
*/
onClose: (removedPanel: IPanel) => void;
onClose: (removedPanel: IPanel<any>) => void;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

related: #4272

@blueprint-bot
Copy link

fix datetime package compilation

Previews: documentation | landing | table

packages/core/src/components/popover/popover.tsx Outdated Show resolved Hide resolved
packages/core/src/components/portal/portal.tsx Outdated Show resolved Hide resolved
packages/core/src/components/slider/handle.tsx Outdated Show resolved Hide resolved
@blueprint-bot
Copy link

more WIP strict null checks in test code

Previews: documentation | landing | table

@blueprint-bot
Copy link

fix tests, address PR self-review

Previews: documentation | landing | table

@adidahiya
Copy link
Contributor Author

clicked through most of the docs examples and everything seems to work fine 🎉

@adidahiya adidahiya merged commit ed3a3e7 into develop Sep 29, 2020
@adidahiya adidahiya deleted the ad/strict-null-checks branch September 29, 2020 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants