[core] fix: force EditableText to respect disabled when alwaysRenderInput is true #4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4329
Checklist
Changes proposed in this pull request:
As mentioned in #4329, EditableText component doesn't respect to disabled prop when alwaysRenderInput is set to true. Normally, disabled prop is not passed to the input element. Instead a span element is displayed when disabled prop is true. However, alwaysRenderInput prop forces component to render input element no matter what. So, I pass disabled prop of EditableText to input element to disabled the input element while rendering it all the time because of alwaysRenderInput.