Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request - tooltip minimal prop and flexibility over arrow #4374

Merged
merged 10 commits into from
Oct 23, 2020
Merged

Feature request - tooltip minimal prop and flexibility over arrow #4374

merged 10 commits into from
Oct 23, 2020

Commits on Oct 19, 2020

  1. Minimal prop and tests for tooltip

    jamesgiu committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    96716b1 View commit details
    Browse the repository at this point in the history

  2. Test for default minimal behaviour and fix class name assignment

    jamesgiu committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    3407d6a View commit details
    Browse the repository at this point in the history

  3. Lint fix

    jamesgiu committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    466aca7 View commit details
    Browse the repository at this point in the history

  4. Run Prettier

    jamesgiu committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    6608ad5 View commit details
    Browse the repository at this point in the history

  5. Fix tests

    jamesgiu committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    6fb7edd View commit details
    Browse the repository at this point in the history

  6. Changing to use arrow instead of arrowOffset, tooltip selector for tests

    jamesgiu committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    bc8dd70 View commit details
    Browse the repository at this point in the history

  7. Ensuring tooltip is open so selector can be found

    jamesgiu committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    8d38184 View commit details
    Browse the repository at this point in the history

  8. Fix formatting fail

    jamesgiu committed Oct 19, 2020
    Configuration menu
    Copy the full SHA
    256a2a3 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2020

  1. Move minimal prop to popoverSharedProps, add tooltipExample for minim… 

    …al prop
    jamesgiu committed Oct 23, 2020
    Configuration menu
    Copy the full SHA
    ab11371 View commit details
    Browse the repository at this point in the history

  2. Update packages/core/src/components/popover/popoverSharedProps.ts

    @adidahiya
    adidahiya authored Oct 23, 2020
    Configuration menu
    Copy the full SHA
    01ecba7 View commit details
    Browse the repository at this point in the history