Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a situation where I wanted to make an alert that had a clear load state (specifically the one supplied by
<Button>
). Because<Alert>
doesn't give allow much control over the buttons, I wound up implementing that solution using a dialog and styling it to look like an alert. I think it would be nice for<Alert>
to have this functionality.Checklist
Changes proposed in this pull request:
Add a loading state to
<Alert>
.Reviewers should focus on:
I'm not familiar with the testing library, so I haven't yet added tests. I can dig into that if maintainers find this to be an acceptable suggestion.
Screenshot