Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] breaking: refactor icons build pipeline to use fantasticon #4505

Merged
merged 12 commits into from
Jan 28, 2021

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Jan 27, 2021

Progress towards #2193

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Remove icon font implementations, have them automatically generated by fantasticon instead
  • Un-deprecate the icon font APIs
  • Split icon paths into multiple files, which will allow us to do A way to only bundle icons you actually use #2193
    • For now, all the icon paths are still exported from the @blueprintjs/icons entry point. An icon loader is not implemented yet.

Reviewers should focus on:

No visual regressions

Screenshot

@blueprint-bot
Copy link

run prettier on iconUtils.ts

Previews: documentation | landing | table

@blueprint-bot
Copy link

remove manual codepoints from icons.json

Previews: documentation | landing | table

@blueprint-bot
Copy link

update icon.md to remove deprecation

Previews: documentation | landing | table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants