[core] fix(Icon): accept standard HTML attributes #4556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
suggested changes
Mar 3, 2021
adidahiya
approved these changes
Mar 3, 2021
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4500
Checklist
Changes proposed in this pull request:
This PR adds standard default HTML attributes to the core Icon component. The motivation was the inability to set a role for icons and with the proposed solution in the linked issue this is now possible.
Reviewers should focus on:
Unfortunately the
IIconPropstype already declares atitleproperty which collides with the definition inHTMLAttributesdue to deviating types. In order to prevent issue in theHTMLSelectcomponent I decided to omit the latter. This fix is open for dicussion.