feat: convert validation errors to console logs #4558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix core testsPreviews: documentation | landing | table |
restore DRI errorPreviews: documentation | landing | table |
revert table validation changesPreviews: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
Replace most of the
throw Error()statements in prop validation lifecycle withconsole.error()logs. Since the validation doesn't run in production, this change will allow developers test their components in a way that more closely matches what their users will see in a production build (they will be able to keep testing their component with invalid props rather than the page crashing).Errors which remain unchanged (components would throw errors anyway if not for this early validation):
<Hotkeys>children validation<MultiSlider>step size & children validation<Toaster>maxToasts validation<DateRangeInput>value validation<Table>validationSee #3407 (comment)