[core] feat(MultistepDialog): allow custom next/back button props per step #4610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adidahiya
suggested changes
Apr 7, 2021
| const dialog = mount( | ||
| <MultistepDialog nextButtonProps={getNextButtonProps} isOpen={true} usePortal={false}> | ||
| <DialogStep id="one" title="Step 1" panel={<Panel />} /> | ||
| <DialogStep id="two" title="Step 2" panel={<Panel />} /> |
There was a problem hiding this comment.
hmm, on second thought, I think a better API would look like this:
<DialogStep id="two" title="Step 2" panel={<Panel />} nextButtonProps={{ disabled: true }} />
since we're calling this.getDialogStepChildren() and accessing each DialogStep's props while rendering the buttons anyway... we can make the API more straightforward and ergonomic this way
adidahiya
suggested changes
Apr 7, 2021
adidahiya
approved these changes
Apr 7, 2021
adidahiya
changed the title
tanmoyopenroot
deleted the
tanmoyopenroot/4579-pass-callback-to-buttonprops
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4579
Checklist
Changes proposed in this pull request:
Provide a way to pass a callback to
backButtonPropsandnextButtonProps