Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type aliases for interfaces renamed in v4.0 #4644

Merged
merged 10 commits into from
Apr 16, 2021
Merged

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented Apr 15, 2021

Changes proposed in this pull request:

  • Add type aliases for I-prefixed interfaces across the public API. This allows 3.x consumers to start using the new names now, which should make it easier to upgrade to 4.0.
    • I covered most of the interfaces, not all (I believe the ones I missed don't have any real usage outside this repo).
    • Interfaces for components which have "v2" versions (Popover, ContextMenuTarget, HotkeysTarget, PanelStack) did not get type aliases; their "v2" versions were already exporting non-prefixed names.
  • Deprecate I-prefixed interfaces across the public API to provide TS hints / lint failures to help with the migration.

@blueprint-bot
Copy link

other packages: add type aliases for renamed interfaces

Previews: documentation | landing | table

@blueprint-bot
Copy link

skip OverlayToaster test

Previews: documentation | landing | table

@blueprint-bot
Copy link

deal with deprecations in docs-app

Previews: documentation | landing | table

@adidahiya adidahiya merged commit 63d5de4 into develop Apr 16, 2021
@adidahiya adidahiya deleted the ad/add-type-aliases branch April 16, 2021 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants