[core] feat(OverflowList): alwaysRenderOverflow prop #4648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ways-render-overflow
2 tasks
fix compilation / lintPreviews: documentation | landing | table |
|
Going to leave it behind the prop for now for backcompat |
code style, documentation tweaksPreviews: documentation | landing | table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4631
Supercedes #4632
Checklist
Changes proposed in this pull request:
Add
alwaysRenderOverflowprop, which forces the overflow renderer to always be called if true.This feature is useful in situations where, for example, the overflow dropdown popover is open and the list items change. In this case you may not want the popover to close.
Reviewers should focus on:
Should this be the default behavior of OverflowList (does it even need to be guarded behind a prop)?
Screenshot
TODO