Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[popover2] feat(ContextMenu2): better disabled behavior #4712

Merged
merged 3 commits into from
May 11, 2021
Merged

[popover2] feat(ContextMenu2): better disabled behavior #4712

merged 3 commits into from
May 11, 2021

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented May 11, 2021 •
edited
Loading

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Do not do extra work (setting mouse event, computing target offset) when the user returns undefined context menu content and is not using the child function render API.
  • This means that users don't have to worry about setting disabled={true} when they set content={undefined}; that API can be reserved for more rare use cases.

@blueprint-bot
Copy link

remove describe.only

Previews: documentation | landing | table

@blueprint-bot
Copy link

update docs examples

Previews: documentation | landing | table

@adidahiya adidahiya merged commit d7a4ca1 into develop May 11, 2021
@adidahiya adidahiya deleted the ad/context-menu2-disabled branch May 11, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adidahiya @blueprint-bot