[popover2] feat(ContextMenu2): forward more props to wrapper el #4713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use HTMLAttributes like other BP APIsPreviews: documentation | landing | table |
adidahiya
commented
May 11, 2021
| /* tslint:disable:object-literal-sort-keys so childNodes can come last */ | ||
| const INITIAL_STATE: TreeNodeInfo[] = [ | ||
| { | ||
| id: 0, | ||
| hasCaret: true, | ||
| icon: "folder-close", | ||
| label: ( | ||
| <ContextMenu2 popoverClassName={Popover2Classes.POPOVER2_CONTENT_SIZING} content={<div>Hello there!</div>}> | ||
| <ContextMenu2 | ||
| popoverProps={{ popoverClassName: Popover2Classes.POPOVER2_CONTENT_SIZING }} |
There was a problem hiding this comment.
forgot to DRY this one
DRYPreviews: documentation | landing | table |
adidahiya
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes proposed in this pull request:
<ContextMenu2>(overlay lifecycle handlers,popoverClassName,transitionDuration) are now moved to an object in thepopoverPropsprop.<ContextMenu2 popoverClassName="foo">→<ContextMenu2 popoverProps={ popoverClassName: "foo" }}><ContextMenu2>now forwards extra HTML props down to the generated wrapper element; consumers can mostly treat it like a<div>now