Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] feat(MultiStepDialog): Allow skipping to a specific step in the dialog #4730

Merged
merged 5 commits into from
May 25, 2021
Merged

[core] feat(MultiStepDialog): Allow skipping to a specific step in the dialog #4730

merged 5 commits into from
May 25, 2021

Conversation

styu
Copy link
Contributor

@styu styu commented May 20, 2021

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Allows for providing an optional initialStepIndex prop which will start the dialog off at the specified step index (0-indexed)
  • If the index < 0, it will start from the first step
  • If the index exceeds the number of steps, it will start from the last step

Reviewers should focus on:

Is there more validation I should be doing?

Screenshot

dialog

@styu styu requested a review from adidahiya May 20, 2021 23:56
@blueprint-bot
Copy link

prettier

Previews: documentation | landing | table

@blueprint-bot
Copy link

lint again

Previews: documentation | landing | table

adidahiya
adidahiya approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine in the PR preview

packages/core/src/components/dialog/multistepDialog.tsx Outdated Show resolved Hide resolved
packages/core/src/components/dialog/multistepDialog.tsx Outdated Show resolved Hide resolved
packages/core/src/components/dialog/multistepDialog.tsx Show resolved Hide resolved
packages/core/src/components/dialog/multistepDialog.tsx Outdated Show resolved Hide resolved
packages/core/src/components/dialog/multistepDialog.tsx Show resolved Hide resolved
packages/core/src/components/dialog/multistepDialog.tsx Show resolved Hide resolved
adidahiya
adidahiya suggested changes May 21, 2021
View reviewed changes
Copy link
Contributor

@adidahiya adidahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I meant to request changes

@blueprint-bot
Copy link

explicit check

Previews: documentation | landing | table

@styu styu merged commit 061762c into develop May 25, 2021
@styu styu deleted the styu/initial-index branch May 25, 2021 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adidahiya adidahiya adidahiya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@styu @blueprint-bot @adidahiya