Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[popover2] fix(Popover2): handle popover v1 dismiss correctly #4736

Merged
merged 4 commits into from
May 27, 2021
Merged

[popover2] fix(Popover2): handle popover v1 dismiss correctly #4736

merged 4 commits into from
May 27, 2021

Conversation

adidahiya
Copy link
Contributor

@adidahiya adidahiya commented May 27, 2021 •
edited
Loading

Fixes #4695, fixes #4691

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Extract reusable implementation of <FilmSelect> component from SelectExample
  • Add <FilmSelect> as a content option for Popover2Example
  • Fix Popover2's dismissal logic to properly check for v1 popover "capture dismiss" class names
  • Fix Popover2 documentation annoying behavior #4691 by adding enforceFocus={false} to the example

Reviewers should focus on:

  • Select example still works
  • Popover2 capture dismiss example still works

Screenshot

2021-05-27 14 21 57

2021-05-27 14 22 22

@blueprint-bot
Copy link

fix test import paths

Previews: documentation | landing | table

@adidahiya adidahiya merged commit a101e75 into develop May 27, 2021
@adidahiya adidahiya deleted the ad/select-popover2-dismiss branch May 27, 2021 18:27
This was referenced Oct 15, 2021
Open
Open
Open
Open
Open
Open
Open
@no-stack-dub-sack no-stack-dub-sack mentioned this pull request Jan 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selecting a menu item closes popover2 automatically Popover2 documentation annoying behavior
2 participants
@adidahiya @blueprint-bot