Add dialog role and tests #4739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like some tests are effectively breaking with this change. I wasn't able to test the project properly yesterday because of some environment issues on my home PC. I was hoping since the change was small they would pass directly in CircleCI, but unfortunately I didn't have such luck. |
|
Closing for now, happy to re-open if you push a new commit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreating pull #4734 so it correctly builds in CircleCI
Fixes #4528
Checklist
Includes tests
Update documentation
Changes proposed in this pull request:
Add dialog role to the Dialog component.
Reviewers should focus on:
Correctness of the test, since the change itself pretty simple.
Screenshot