[popover2] fix(ContextMenu2): detect dark theme correctly #4756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor renamePreviews: documentation | landing | table |
|
This solution doesn't work because the popper ref needs to be attached to the root node returned from |
attach ref to containerPreviews: documentation | landing | table |
fix code commentPreviews: documentation | landing | table |
This was referenced Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4743
Checklist
Changes proposed in this pull request:
<div>rendered as the popover target, so that we can attach a ref to it and properly query for dark theme. Before this change, we were checking for dark theme on the "virtual" target we rendered inside a<Portal>, which will almost always be an invalid check since applications rarely add.bp3-darkto the<body>element.Classes.CONTEXT_MENU2_POPOVER2_TARGETtoClasses.CONTEXT_MENU2_VIRTUAL_TARGETrefproperty back toContextMenu2ChildrenPropsafter it was removed in [popover2] fix(ContextMenu2): simpler target positioning logic #4740 (sorry for the API whiplash). If upgrading from popover2> 0.8.0 < 0.11.0and you are using the advanced children render function API, you'll need to attach this ref to whatever you return from the children render function.Reviewers should focus on:
N/A
Screenshot