Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] feat(useHotkeys): accept custom document for global handlers #4773

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

adidahiya
Copy link
Contributor

Fixes #4731

Checklist

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

Add document to UseHotkeysOptions, and use this value (if provided) in the useHotkeys hook when binding global event handlers.

Reviewers should focus on:

Screenshot

@blueprint-bot
Copy link

[core] feat(useHotkeys): accept custom document for global handlers

Previews: documentation | landing | table

@adidahiya adidahiya merged commit f752acc into develop Jun 22, 2021
@adidahiya adidahiya deleted the ad/hotkeys-document branch June 22, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useHotkeys from within an iframe
2 participants